Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rumtime): disable server-timing header via options.timing #823

Merged
merged 11 commits into from
Jan 13, 2023
Merged

fix(rumtime): disable server-timing header via options.timing #823

merged 11 commits into from
Jan 13, 2023

Conversation

clarkdo
Copy link
Contributor

@clarkdo clarkdo commented Jan 10, 2023 •
edited
Loading

πŸ”— Linked issue

Fix nuxt/nuxt#15660

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)

πŸ“š Description

timing config is for enabling bundles loading time instead of timing header, this pr is improving the accuracy of description.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@clarkdo clarkdo requested a review from pi0 January 10, 2023 13:18
@codecov
Copy link

codecov bot commented Jan 10, 2023 •
edited
Loading

Codecov Report

Merging #823 (ca198e1) into main (ae708f0) will increase coverage by 0.53%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     nuxt/framework#823      +/-   ##
==========================================
+ Coverage   69.93%   70.46%   +0.53%     
==========================================
  Files          57       57              
  Lines        5312     5316       +4     
  Branches      594      604      +10     
==========================================
+ Hits         3715     3746      +31     
+ Misses       1588     1561      -27     
  Partials        9        9
Impacted Files Coverage Ξ”
src/nitro.ts 87.77% <100.00%> (+0.56%) ⬆️
src/rollup/config.ts 91.35% <0.00%> (+0.46%) ⬆️
src/rollup/plugins/timing.ts 91.66% <0.00%> (+52.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@clarkdo clarkdo changed the title docs: fix options.timing description fix(rumtime): disable server-timing header via options.timing Jan 10, 2023
@clarkdo clarkdo requested a review from danielroe January 11, 2023 15:37
danielroe
danielroe reviewed Jan 11, 2023
View reviewed changes
src/runtime/app.ts Outdated Show resolved Hide resolved
danielroe
danielroe reviewed Jan 12, 2023
View reviewed changes
src/runtime/timing.ts Outdated Show resolved Hide resolved
@clarkdo clarkdo requested a review from danielroe January 12, 2023 15:11
pi0
pi0 approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks πŸ’― Nice idea using plugins to opt-in

@pi0 pi0 merged commit ed3a480 into main Jan 13, 2023
@pi0 pi0 deleted the docs/timing branch January 13, 2023 16:27
pi0 pushed a commit that referenced this pull request Jan 16, 2023
@clarkdo @pi0
fix(rumtime): disable server-timing header via options.timing (#823)
7b12389
@oritwoen oritwoen mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@danielroe danielroe Awaiting requested review from danielroe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

server-timing header is always returned even when turned off
3 participants
@clarkdo @pi0 @danielroe