Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure legacy runtime config types are populated #2724

Merged
merged 4 commits into from
Sep 10, 2024
Merged

fix: ensure legacy runtime config types are populated #2724

merged 4 commits into from
Sep 10, 2024

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Context: nuxt/nuxt#28924, https://github.com/nuxt/ecosystem-ci/actions/runs/10799722624.

Currently changes to NitroRuntimeConfig and NitroRuntimeConfigApp are breaking for users/modules consuming nitropack.

This ensures types imported from nitropack aren't breaking.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working types v2 labels Sep 10, 2024
@danielroe danielroe requested a review from pi0 September 10, 2024 20:38
@danielroe danielroe self-assigned this Sep 10, 2024
pi0
pi0 reviewed Sep 10, 2024
View reviewed changes
src/core/index.ts Outdated Show resolved Hide resolved
pi0
pi0 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!🙏

@pi0 pi0 merged commit d3880b9 into v2 Sep 10, 2024
4 of 5 checks passed
@pi0 pi0 deleted the fix/legacy-types branch September 10, 2024 20:59
This was referenced Sep 10, 2024
Merged
Closed
@pi0 pi0 mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
bug Something isn't working types v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0