Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add genezio preset #2637

Merged
merged 6 commits into from
Sep 5, 2024
Merged

feat: add genezio preset #2637

merged 6 commits into from
Sep 5, 2024

Conversation

tudorpip
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Genezio is a Function-as-a-Service (FaaS) platform designed to deploy serverless applications efficiently, minimizing both costs and cold start times.

I have introduced a new preset named --genezio. This preset provides users with additional configuration options, allowing for more flexibility and customization.

Additionally, I have updated the documentation to reflect these changes, ensuring that users can easily understand and utilize the new preset.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

tudorpip and others added 3 commits July 30, 2024 10:35
* Added genezio preset

* Auto-generate genezio file

* Enable custom names and default region for yaml file

* Create genezio.yaml

* Basic draft of genezio.md file

* Update genezio.md

* Update for the auto-generation of the yaml files

* Update index.ts

* Update genezio.md

* Update genezio.md

* Update genezio.md

* Update genezio.md

* Update genezio.md

* Update genezio.md

Co-authored-by: Andreia OcΔƒnoaia <[email protected]>

* Update genezio.md

* Update genezio.md

* Update genezio.md

* Reverted the accidental changes to _all.gen

* Reverted the playground changes

* Update genezio.md

---------

Co-authored-by: Andreia OcΔƒnoaia <[email protected]>
@tudorpip
Copy link
Contributor Author

tudorpip commented Aug 7, 2024

Hey @pi0, I've tested this feature and it's ready for a code review. Feel free to add yourself as a reviewer anytime.
I am really looking forward to merging this new exciting feature πŸš€.

},
{
name: "genezio" as const,
stdName: "genezio",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdName needs to be recognized with unjs/std-env

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(removed for now)

const name = await getNameFromPackage();
const initialPath = dirname(nitro.options.output.dir);
const genezioConfigPath = resolve(initialPath, "genezio.yaml");
const genezioConfigContent = `
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally zero config nitro presets use a special "output directory" that is supported by deployment providers instead of writing to project root (which is version controlled)

If manual file is required, we should keep it as docs only (i would be happy to explain this more if you like to integrate zero deploy with your platform)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(moved to the docs for now)

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR ❀️ Merging it to be able to do e2e test via nightly release channel. For next steps, it would be amazing if you can join our discord channel (shared invitation in X)

@pi0 pi0 merged commit bb20b8d into nitrojs:v2 Sep 5, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants