Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jiti v1.21.1 breaks Docusaurus #237

Closed
slorber opened this issue Jun 5, 2024 · 5 comments
Closed

Jiti v1.21.1 breaks Docusaurus #237

slorber opened this issue Jun 5, 2024 · 5 comments

Comments

@slorber
Copy link

slorber commented Jun 5, 2024

Environment

Jiti v1.21.1 does not seem to be retro-compatible with v1.21.0 and breaks Docusaurus usage due to dependency being upgraded

facebook/docusaurus#10199

Reproduction

yarn create docusaurus

It fails on yarn start

But it gets fixed once we resolve to former Jiti version

  "resolutions": {
    "jiti": "1.21.0"
  },

Describe the bug

Not sure exactly what happens here but it looks like Docusaurus does not see anymore the named export callbacks we call by convention on our Docusaurus plugins.

var options_1 = require("./options");
Object.defineProperty(exports, "validateOptions", { enumerable: true, get: function () { return options_1.validateOptions; } });

The validateOptions export should be called by Docusaurus core, but it is not called anymore, so it seems modules loaded by Jiti are slightly different from before.

Additional context

No response

Logs

No response

@pi0
Copy link
Member

pi0 commented Jun 5, 2024

Hi dear @slorber. It is a pitty if it is a regressed behavior of babel... I will investigate and keep you updated.

@slorber
Copy link
Author

slorber commented Jun 5, 2024

Thanks for investigating. Sorry not to be more helpful, I'm on holiday 😅

@Jungzl
Copy link

Jungzl commented Jun 5, 2024

Also breaks UnoCSS unocss/unocss#3869

@pi0 pi0 closed this as completed in 7691c82 Jun 5, 2024
@pi0
Copy link
Member

pi0 commented Jun 5, 2024

Just released [email protected] as hotfix for this issue you can upgrade lockfile for the fix.

Recent improvements in mlly.interopdefault seems caused this. (followup investigation: #238)

@homotechsual
Copy link

Just released [email protected] as hotfix for this issue you can upgrade lockfile for the fix.

Recent improvements in mlly.interopdefault seems caused this.

Amazing, thanks so much for the prompt fix and release on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants