fix: don not log errors when onError is provided

[danielroe]

Currently we get two copies of error logs if we are logging them in a user-provided onError handler. Presumably it makes sense for user to log (or not) if they are providing their own error handler

[codecov]

Codecov Report

Merging #162 (15379c7) into main (a8fa857) will increase coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   65.40%   65.47%   +0.07%     
==========================================
  Files          14       14              
  Lines         922      921       -1     
  Branches      200      200              
==========================================
  Hits          603      603              
+ Misses        124      123       -1     
  Partials      195      195              

Impacted Files	Coverage Δ
src/app.ts	68.20% <0.00%> (+0.39%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[pi0]

This change makes sense but is slighly breaking. We need to update two places at least:

• https://github.com/nuxt/framework/blob/97f0fa511a10c25bcea0618799fe7319639c2c20/packages/nuxt/src/core/runtime/nitro/error.ts#L28 (fatal handler)
• https://github.com/unjs/nitro/blob/e10f1307d765b0ac35e5492c14f804086569ac91/src/runtime/error.ts#L15 (currently nitro uses no console logs)

[danielroe]

I don't think we need to update the framework code. That line is already logging the error to the console.

And I'm probably misunderstanding, but don't we already log in https://github.com/unjs/nitro/blob/e10f1307d765b0ac35e5492c14f804086569ac91/src/runtime/error.ts#L29-L31 ?

For example, see https://stackblitz.com/edit/github-p8e2d2?file=routes%2Findex.ts - you can see both h3 + nitro logs on the console.

[pi0]

I missed nitro one but neither are handling .fatal flag (nuxt ignores it i guess even)

[danielroe]

Good point! In that case it's not breaking, but just incremental improvement to suppressing logging for non-fatal, non-unhandled errors. I'll follow up with PRs to framework + nitro.