Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow string[] in arg signature #56

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fix: allow string[] in arg signature #56

merged 1 commit into from
Aug 24, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently we have an issue when spreading parsed args as the resulting type has a signature that is not compatible with the type of _.

You might want to prevent array type from key signature for another reason - if so, let's chat.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Aug 24, 2023
@danielroe danielroe requested a review from pi0 August 24, 2023 14:24
@danielroe danielroe self-assigned this Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #56 (42b1b75) into main (d7a601d) will not change coverage.
The diff coverage is n/a.

@@    Coverage Diff     @@
##   main   #56   +/-   ##
==========================
==========================

@pi0 pi0 merged commit 7f78a39 into main Aug 24, 2023
@pi0 pi0 deleted the fix/key-signature branch August 24, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants