Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript bug when enable { strict: true } #37

Closed
yidingww opened this issue May 26, 2023 · 1 comment · Fixed by #38
Closed

Typescript bug when enable { strict: true } #37

yidingww opened this issue May 26, 2023 · 1 comment · Fixed by #38

Comments

@yidingww
Copy link
Contributor

yidingww commented May 26, 2023 •
edited
Loading

Environment

citty 0.1.11
nodejs 16
pnpm 8

Reproduction

https://stackblitz.com/edit/stackblitz-starters-kvn1gq?file=src%2Findex.ts

Describe the bug

Type 'ParsedArgs<ArgsDef>' is not assignable to type 'Record<"blah", string>'

image

TS config:

{
  "compilerOptions": {
    "target": "ESNext",
    "module": "ESNext",
    "moduleResolution": "Node",
    "esModuleInterop": true,
    "strict": true
  },
  "include": ["src"]
}

Additional context

The ts error is gone when i set strict to false in tsconfig.json

Logs

No response
@yidingww yidingww mentioned this issue May 30, 2023
Merged
@yidingww
Copy link
Contributor Author

@pi0 created a PR #38 to fix this 🙏🏻

@pi0 pi0 closed this as completed in #38 Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix generic type issues yidingww/citty
1 participant
@yidingww