units.py: Fix format-NlKkFnP on Windows #4137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-takata
force-pushed
the
fix-format-NlKkFnP-on-windows
branch
from
4645488 to
0888564
Compare
The format-NlKkFnP test starts failing after MSYS2's python has been updated from python-3.12.7-2 to python-3.12.7-3. It seems that shutil.which() fails in python-3.12.7-3. Check the existence of the filter file on Windows. Also, fixed a typo in CMDLINE.tmp. Fixes universal-ctags#4132.
k-takata
force-pushed
the
fix-format-NlKkFnP-on-windows
branch
from
0888564 to
9be79ab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4137 +/- ##
=======================================
Coverage 85.89% 85.89%
=======================================
Files 239 239
Lines 58695 58695
=======================================
Hits 50416 50416
Misses 8279 8279 ☔ View full report in Codecov by Sentry. |
|
The failing of |
|
Thank you very much. |
masatake
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format-NlKkFnP test starts failing after MSYS2's python has been updated from python-3.12.7-2 to python-3.12.7-3.
It seems that shutil.which() fails in python-3.12.7-3. Check the existence of the filter file on Windows.
Also, fixed a typo in CMDLINE.tmp.
Fixes #4132.