Added the IQR Detector #2441
Merged
Added the IQR Detector #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2441 +/- ##
==========================================
- Coverage 93.79% 93.79% -0.01%
==========================================
Files 138 139 +1
Lines 14654 14666 +12
==========================================
+ Hits 13745 13756 +11
- Misses 909 910 +1 ☔ View full report in Codecov by Sentry. |
dennisbader
requested changes
Jul 3, 2024
There was a problem hiding this comment.
Thanks for this great PR @u8-igor, it already looks really good 🚀
Your code is well-written.
I just added a couple of minor suggestions where we could try to simplify a bit here and there.
Co-authored-by: Dennis Bader <[email protected]>
dennisbader
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Looks perfect now, thanks a lot @u8-igor 🚀 Ready to merge once all tests have passed 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before merging this PR:
Closes #2319.
Summary
Added IQRDetector, allowing for detecting anomalies using the interquartile range algorithm.
It is based on the QuantileDetector and has a
scaleparameter for adjusting the acceptable range.Other Information