bugfix: don't consider shortening variables with use statements #5465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #5464
There was a bug in the logic that considers when/where to place
usestatements that was causing occasional misprinting of code. This PR fixes the bug and adds a regression test.Implementation notes
Removed line of code that treated variables as targets for
use-statement insertion.For example, we'd previously consider shortening a variable
foo.bar.baztobar.baz(via ause foo bar.baz) orbaz(via ause foo.bar baz). Now, we'll leave variables likefoo.bar.bazalone.There may be an even smarter fix that safely inserts
useto shorten variable names... but perhaps that could be implemented separately from the immediate bugfix. I also think it's probably fine to restrictuseto shortening names for external references, not local variables (as this PR implements).Test coverage
Transcript added, failing in first commit