Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display check crashes ucm #2144

Open
LoPoHa opened this issue Jun 24, 2021 · 5 comments
Open

display check crashes ucm #2144

LoPoHa opened this issue Jun 24, 2021 · 5 comments

Comments

@LoPoHa
Copy link

LoPoHa commented Jun 24, 2021

See the title.
I assume check is a builtin and it happens with other functions?

.> display check
ucm: can't serialize term with blanks
CallStack (from HasCallStack):
  error, called at src/Unison/Codebase/SqliteCodebase/Conversions.hs:122:26 in unison-parser-typechecker-0.0.0-DaPEC8BhFLfBuvI7Fapoon:Unison.Codebase.SqliteCodebase.Conversions
@LoPoHa
Copy link
Author

LoPoHa commented Jun 24, 2021

display putBytes
ucm: unimplemented: symbol1to2 Pattern-1
CallStack (from HasCallStack):
  error, called at src/Unison/Codebase/SqliteCodebase/Conversions.hs:246:16 in unison-parser-typechecker-0.0.0-DaPEC8BhFLfBuvI7Fapoon:Unison.Codebase.SqliteCodebase.Conversions

It seems to happen with builtins

@hojberg
Copy link
Member

hojberg commented Jun 24, 2021

I also get this with List.map (which isn't a builtin).

@LoPoHa
Copy link
Author

LoPoHa commented Jun 24, 2021

Looking at it again, the errors in display check and display putBytes or display List.map are a different.
display check has the error ucm: can't serialize term with blanks while display putBytes and display List.map have the error ucm: unimplemented: symbol1to2 Pattern-1
Should these be separated issues?

@pchiusano
Copy link
Member

@LoPoHa any chance you can try this again with current trunk?

The ones that have the unimplemented: symbol1to2 should have been fixed by #2138. I'm less sure about the other ones though.

@aryairani
Copy link
Contributor

aryairani commented Jun 29, 2021

@pchiusano putBytes displays now, but with the same wrong variable names we saw in #2138 / #2153

_M2.test.internals.v1.Test.check still bombs with can't serialize term with blanks. I don't know why evaluating check would produce a term with blanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants