Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add an Ad to multiple zones #1

Open
wernerkrauss opened this issue Feb 11, 2015 · 3 comments
Open

Cannot add an Ad to multiple zones #1

wernerkrauss opened this issue Feb 11, 2015 · 3 comments

Comments

@wernerkrauss
Copy link

Hi,
i want some ads be on HomePage and on AnotherPage, some ads just on HomePage, some just at AnotherPage.

But one Ad can just have one Zone by now.

Would you mind if the Ad - Zone relation was changed from has_one / has_many to a many_many?

Child zones won't work for me, as some ads should just be in one zone, some in both.

@elvinas-liut
Copy link
Member

I don't see any reason why it cannot be changed to many_many 👍
Can you make pull request?

@wernerkrauss
Copy link
Author

Well, the biggest "problem" for now is to understand that query that gets the ads using a subselect... See https://github.com/unisolutions/silverstripe-uniads/blob/master/code/extensions/UniadsExtension.php#L76 and following lines. Are you on IRC sometimes so we could discuss it together? I'd be happy to refactor that, too, and create a pull request.

@elvinas-liut
Copy link
Member

Sure. I'll be on IRC from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants