Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to avoid tinycolor2 dependency when using a custom Loader ? #86

Closed
bpetetot opened this issue Nov 13, 2017 · 1 comment
Closed

How to avoid tinycolor2 dependency when using a custom Loader ? #86

bpetetot opened this issue Nov 13, 2017 · 1 comment

Comments

@bpetetot
Copy link
Collaborator

In the documentation, it's written :

tinycolor2 is a peer dependency of hoc-react-loader. It handles color picking for the default loading indicator. You don't have to install it if you use your own loading indicator.

But if I do import loader from 'hoc-react-loader', it crash if I don't have tinycolor2 as dependency. (I am using my own custom loader)

I have to import it like that import from 'hoc-react-loader/build/core' to avoid tinycolor2 dependency.
But if the build structure change, I will have a problem with that kind of import.

How could we import hoc-react-loader as default without having tinycolor2 dependency ?

@fabienjuif
Copy link
Member

see #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants