Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds documentation for virtual bridge error #183

Closed

Conversation

levihackerman-102
Copy link

Fixes #182

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this.

Besides the comments, please sign-off your commit and change the message to something more explicit (something like: hack/sessions: Document qemu bridge acces denied error).

Also, should deleting the allow all line form the /etc/qemu/bridge.conf file reproduce this issue? I tried doing that and reloading the qemu-kvm service but the command still worked.

@levihackerman-102
Copy link
Author

levihackerman-102 commented Jan 19, 2023

@StefanJum I've made the required changes

@levihackerman-102
Copy link
Author

Also, should deleting the allow all line form the /etc/qemu/bridge.conf file reproduce this issue? I tried doing that and reloading the qemu-kvm service but the command still worked.

Interesting, it does create an issue on my system and seems to be a common problem. Not sure why it doesn't reproduce on your system.

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StefanJum, @levihackerman-102, I added a comment. I got this error in the past, but it's only for certain systems / use cases. Not sure what's causing some systems to require it or some others, such as @StefanJum's system, do not cause the issue.

@levihackerman-102 levihackerman-102 requested review from razvand and removed request for StefanJum January 23, 2023 01:00
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment. Besides this, please also squash your commits.

@levihackerman-102 levihackerman-102 force-pushed the virbr-docs-add branch 3 times, most recently from 4042e12 to cfcec47 Compare March 11, 2023 10:54
@levihackerman-102
Copy link
Author

@StefanJum made the changes

@StefanJum
Copy link
Member

Looks good now @levihackerman-102, just modify the commit message to contain only the description of the changes and your sign-off, then we can merge this.

@levihackerman-102
Copy link
Author

Ahh my bad, fixed it @StefanJum

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks @levihackerman-102. @razvand please take a look so we can merge this.

Reviewed-by: Stefan Jumarea [email protected]
Approved-by: Stefan Jumarea [email protected]

@StefanJum
Copy link
Member

No longer required after updates to the Unikraft website.

@StefanJum StefanJum closed this Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for resolving virtual bridge error when running qemu
3 participants