-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds documentation for virtual bridge error #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this.
Besides the comments, please sign-off your commit and change the message to something more explicit (something like: hack/sessions: Document qemu bridge acces denied error
).
Also, should deleting the allow all
line form the /etc/qemu/bridge.conf
file reproduce this issue? I tried doing that and reloading the qemu-kvm
service but the command still worked.
...hons/sessions/baby-steps/content/Demos_02.-Building-and-Running-the-httpreply-Application.md
Outdated
Show resolved
Hide resolved
...hons/sessions/baby-steps/content/Demos_02.-Building-and-Running-the-httpreply-Application.md
Outdated
Show resolved
Hide resolved
1481383
to
f9d24d9
Compare
@StefanJum I've made the required changes |
Interesting, it does create an issue on my system and seems to be a common problem. Not sure why it doesn't reproduce on your system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StefanJum, @levihackerman-102, I added a comment. I got this error in the past, but it's only for certain systems / use cases. Not sure what's causing some systems to require it or some others, such as @StefanJum's system, do not cause the issue.
...hons/sessions/baby-steps/content/Demos_02.-Building-and-Running-the-httpreply-Application.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment. Besides this, please also squash your commits.
...hons/sessions/baby-steps/content/Demos_02.-Building-and-Running-the-httpreply-Application.md
Show resolved
Hide resolved
4042e12
to
cfcec47
Compare
@StefanJum made the changes |
Looks good now @levihackerman-102, just modify the commit message to contain only the description of the changes and your sign-off, then we can merge this. |
Signed-off-by: Anshul Singh <[email protected]>
cfcec47
to
fef0674
Compare
Ahh my bad, fixed it @StefanJum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now, thanks @levihackerman-102. @razvand please take a look so we can merge this.
Reviewed-by: Stefan Jumarea [email protected]
Approved-by: Stefan Jumarea [email protected]
No longer required after updates to the Unikraft website. |
Fixes #182