Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved dataset indexing #134

Closed
dopplershift opened this issue Jun 30, 2017 · 0 comments
Closed

Improved dataset indexing #134

dopplershift opened this issue Jun 30, 2017 · 0 comments
Assignees
@dopplershift
Labels
Area: Catalog Type: Enhancement
Milestone
0.5

Comments

@dopplershift
Copy link
Member

dopplershift commented Jun 30, 2017 •
edited
Loading

Replace the TDSCatalog.datasets dictionary with a thin data structure that allows indexing:

  • positionally
  • by dataset name
cat = TDSCatalog(...)
cat.datasets[0]
cat.dataset['GEFS_Global_1p0deg_Ensemble_ana_20170617_0000.grib2']

This can be done in a backwards compatible manner by having the new datasets attribute (of type DatasetCollection?) inherit dict.
@dopplershift dopplershift added this to the Summer 2017 milestone Jun 30, 2017
@dopplershift dopplershift mentioned this issue Jul 19, 2017
Closed
2 tasks
dopplershift added a commit to dopplershift/siphon that referenced this issue Jul 20, 2017
@dopplershift
ENH: Add ability to access datasets by index (Fixes Unidata#134)
b924314 
When getting an item by string, work as before. For all else, treat as
an index into values. Works for catalog refs as well.
@dopplershift dopplershift mentioned this issue Jul 20, 2017
Merged
dopplershift added a commit to dopplershift/siphon that referenced this issue Jul 21, 2017
@dopplershift
ENH: Add ability to access datasets by index (Fixes Unidata#134)
55d7e7b 
When getting an item by string, work as before. For all else, treat as
an index into values. Works for catalog refs as well.
dopplershift added a commit to dopplershift/siphon that referenced this issue Jul 21, 2017
@dopplershift
ENH: Add ability to access datasets by index (Fixes Unidata#134)
fbe1df0 
When getting an item by string, work as before. For all else, treat as
an index into values. Works for catalog refs as well.
dopplershift added a commit to dopplershift/siphon that referenced this issue Jul 21, 2017
@dopplershift
ENH: Add ability to access datasets by index (Fixes Unidata#134)
ad03cec 
When getting an item by string, work as before. For all else, treat as
an index into values. Works for catalog refs as well.
dopplershift added a commit to dopplershift/siphon that referenced this issue Jul 21, 2017
@dopplershift
ENH: Add ability to access datasets by index (Fixes Unidata#134)
c3d0b3a 
When getting an item by string, work as before. For all else, treat as
an index into values. Works for catalog refs as well.
@dopplershift dopplershift self-assigned this Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dopplershift dopplershift

Labels
Area: Catalog Type: Enhancement
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@dopplershift