Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NCSS validate_query with no variables #102

Closed
dopplershift opened this issue May 17, 2016 · 0 comments
Closed

NCSS validate_query with no variables #102

dopplershift opened this issue May 17, 2016 · 0 comments
Assignees
@dopplershift
Labels
Area: NCSS Type: Bug
Milestone
0.5

Comments

@dopplershift
Copy link
Member

dopplershift commented May 17, 2016 •
edited
Loading 

from siphon.ncss import NCSS
ncss = NCSS('http://thredds.ucar.edu/thredds/ncss/nws/metar/ncdecoded/Metar_Station_Data_fc.cdmr')
query = ncss.query()
ncss.validate_query(query)

returns set()

Looks like the nice short-circuit behavior results in the return of the empty variable query--I think a call to bool() is in order.
@dopplershift dopplershift added this to the Summer 2017 milestone Jun 30, 2017
@dopplershift dopplershift self-assigned this Jul 21, 2017
dopplershift added a commit that referenced this issue Jul 22, 2017
@dopplershift
Merge pull request #143 from dopplershift/fix-102
7ffbe95 
BUG: Fix empty set returned from validate_query (Fixes #102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dopplershift dopplershift

Labels
Area: NCSS Type: Bug
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@dopplershift