You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#5842 changed the argument of AnyCalendar::new_for_locale to take AnyCalendarPreferences instead of Locale, but it did not change the name of the function.
Please note that there is already another function AnyCalendar::new that takes an AnyCalendarKind.
Should we:
Leave things the way they are now
Change the new function to work with preferences and change the AnyCalendarKind constructor to be new_for_kind
Change new_for_locale to new_for_preferences
Add new_for_preferences and keep new_for_locale the way it was before
#5842 changed the argument of
AnyCalendar::new_for_locale
to take AnyCalendarPreferences instead of Locale, but it did not change the name of the function.Please note that there is already another function
AnyCalendar::new
that takes anAnyCalendarKind
.Should we:
new
function to work with preferences and change the AnyCalendarKind constructor to benew_for_kind
new_for_locale
tonew_for_preferences
new_for_preferences
and keepnew_for_locale
the way it was beforeI would rather not make this decision myself.
Needs input from: @zbraniecki @Manishearth and others
The text was updated successfully, but these errors were encountered: