Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnyCalendar locale constructor naming #5843

Closed
sffc opened this issue Nov 20, 2024 · 2 comments · Fixed by #5855
Closed

AnyCalendar locale constructor naming #5843

sffc opened this issue Nov 20, 2024 · 2 comments · Fixed by #5855
Labels
C-calendar Component: Calendars needs-approval One or more stakeholders need to approve proposal

Comments

@sffc
Copy link
Member

sffc commented Nov 20, 2024

#5842 changed the argument of AnyCalendar::new_for_locale to take AnyCalendarPreferences instead of Locale, but it did not change the name of the function.

Please note that there is already another function AnyCalendar::new that takes an AnyCalendarKind.

Should we:

  1. Leave things the way they are now
  2. Change the new function to work with preferences and change the AnyCalendarKind constructor to be new_for_kind
  3. Change new_for_locale to new_for_preferences
  4. Add new_for_preferences and keep new_for_locale the way it was before
  5. ?

I would rather not make this decision myself.

Needs input from: @zbraniecki @Manishearth and others

@sffc sffc added needs-approval One or more stakeholders need to approve proposal C-calendar Component: Calendars labels Nov 20, 2024
@sffc sffc added this to the ICU4X 2.0 ⟨P1⟩ milestone Nov 20, 2024
@Manishearth
Copy link
Member

Manishearth commented Nov 20, 2024

No strong preference, but: 4 ~> 2 ~> 3 ~> 1

@zbraniecki
Copy link
Member

2 >> 3 >> 1 = 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-calendar Component: Calendars needs-approval One or more stakeholders need to approve proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants