Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support leap months in datetime #3766

Closed
atcupps opened this issue Aug 2, 2023 · 2 comments
Closed

Support leap months in datetime #3766

atcupps opened this issue Aug 2, 2023 · 2 comments
Assignees
@sffc @Manishearth
Labels
C-datetime Component: datetime, calendars, time zones
Milestone
2.x Priority ⟨P2⟩

Comments

@atcupps
Copy link
Contributor

atcupps commented Aug 2, 2023

Currently, #3760 supports leap months with a placeholder by writing (leap) before a leap month because the infrastructure to generate leap month data and include it in formatted datetimes does not exist. This is similar to but separate from #3761. I discussed this with @sffc and @Manishearth and they formed a plan to address this.
@Manishearth Manishearth added this to the 1.3 Blocking ⟨P1⟩ milestone Aug 11, 2023
@Manishearth Manishearth mentioned this issue Aug 15, 2023
Closed
@sffc sffc added the discuss Discuss at a future ICU4X-SC meeting label Aug 24, 2023
@Manishearth
Copy link
Member

Manishearth commented Aug 24, 2023 •
edited
Loading

Plan for this for 1.3 is to implement hardcoded mostly-correct behavior

#3865 (comment)

@Manishearth Manishearth mentioned this issue Sep 1, 2023
Merged
@sffc sffc added C-datetime Component: datetime, calendars, time zones and removed discuss Discuss at a future ICU4X-SC meeting labels Sep 5, 2023
This was referenced Oct 24, 2023
Merged
Closed
Merged
@Manishearth Manishearth moved this to Being worked on in icu4x 2.0 Feb 23, 2024
@Manishearth
Copy link
Member

This is supported in neo.

@github-project-automation github-project-automation bot moved this from Being worked on to Done in icu4x 2.0 Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sffc sffc

@Manishearth Manishearth

Labels
C-datetime Component: datetime, calendars, time zones
Projects
icu4x 2.0
Status: Done
Milestone
2.x Priority ⟨P2⟩
Development

No branches or pull requests
3 participants
@sffc @Manishearth @atcupps