plot_topoplotseries colorbars still broken

[behinger]

UnfoldMakie.jl/src/plot_topoplotseries.jl

Line 127 in f5ed699

cb_limits = (minimum(data.val.estimate), maximum(data.val.estimate)) # set limits for colorbar

this is a bad way to define default colorranges, why not use extract_colorrange a function that is already defined?

---

besides that, I cannot get non-symmetric colorbars anymore. colorrange seems to be ignored?

tp_pvalues = plot_topoplotseries!(
    f_pvalues,
    p_values_df;
    bin_width,
    positions = pos2d,
    mapping = (; y = :estimate),
    visual = (; enlarge = 0.6, label_scatter = false, colorrange = (0, 0.1)),
    colorbar = (; label = "p-value"),
)

I couldnt find in the code why/where this breaks yet

[behinger]

ok sorry I havent actually used the newest UnfoldMakie version. Now I do, it is still broken, but differently :-P

So colorrange is not respected when calculating limits of colorbar, this is a bug I can see directly from the code. I can circumvent this, by not specifying colorrange, but limits directly - but then the labels are wrong...

[vladdez]

and what it the current issue? @behinger

[behinger]

So colorrange is not respected when calculating limits of colorbar, this is a bug I can see directly from the code. I can circumvent this, by not specifying colorrange, but limits directly - but then the labels are wrong...