Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy mixture of function parameter types #210

Open
RobH123 opened this issue Sep 6, 2021 · 1 comment
Open

Tidy mixture of function parameter types #210

RobH123 opened this issue Sep 6, 2021 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@RobH123
Copy link
Contributor

RobH123 commented Sep 6, 2021

Some functions use parameters, e.g., functionA(username, languageCode, ...);

Others (mostly functions written by other uW programmers) pass objects, e.g., functionB({ username: adjustedUsername, languageCode, ...});

Having both forms is both confusing and error-prone.

Find out:

  1. Which is the most efficient form? What is the cost of the alternate form?
  2. Which is the preferred form? What do other uW codebases use?

Then decide which is best and make this code more consistent.

@RobH123 RobH123 added enhancement New feature or request question Further information is requested labels Sep 6, 2021
@RobH123 RobH123 changed the title Tidy mix of function parameters Tidy mixture of function parameter types Sep 6, 2021
@mandolyte
Copy link
Contributor

Note to self @mandolyte ; consider above...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants