Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation of duplicate PR on tcCreate #1654

Closed
elsylambert opened this issue Jan 23, 2025 · 3 comments · Fixed by #1658
Closed

Creation of duplicate PR on tcCreate #1654

elsylambert opened this issue Jan 23, 2025 · 3 comments · Fixed by #1658
Assignees
@abelpz

Comments

@elsylambert
Copy link
Contributor

elsylambert commented Jan 23, 2025 •
edited
Loading

Some cases where users can have two PRs for the same merge.

  • It can happen when users tries to merge their work, but selects CANCEL on the modal.

Image
@elsylambert
Copy link
Contributor Author

@abelpz Can you please take a look at the Merge my work code to see if the logic somehow creates a PR before user hits Submit button?

@abelpz
Copy link
Member

abelpz commented Jan 23, 2025

Sure I'll check @elsylambert

@abelpz abelpz self-assigned this Jan 24, 2025
@abelpz
Copy link
Member

abelpz commented Jan 27, 2025 •
edited
Loading

@elsylambert duplicate PRs are being created even without merging. Will add some steps to reproduce.

@abelpz abelpz mentioned this issue Jan 27, 2025
Merged
18 tasks
@elsylambert elsylambert mentioned this issue Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abelpz abelpz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent duplicate PRs to be created unfoldingWord/tc-create-app
2 participants
@abelpz @elsylambert