Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter do not show verse ranges correctly #1530

Closed
elsylambert opened this issue Feb 3, 2023 · 1 comment · Fixed by #1536
Closed

Filter do not show verse ranges correctly #1530

elsylambert opened this issue Feb 3, 2023 · 1 comment · Fixed by #1536
Assignees
@abelpz
Labels
QA/Passed QA Completed

Comments

@elsylambert
Copy link
Contributor

elsylambert commented Feb 3, 2023 •
edited
Loading

The filter does not show the verse range correctly.

  • Open TCC> open tN> Select a file. ex Book of Psalms.
  • In the filter selection, filter by chapter. TCC shows the notes for that chapter.
  • Edit any row, by adding a verse range. Ex, Reference 120:2 to 120:2,6 and Save.
  • Add a new row with Reference 120:2-3.
  • Open filter and see that for 120, for chapter 120: verse 2, 120:2,6 and 120_2-3, shows as 2
    Screenshot 2023-02-03 at 9.47.22 AM.png

Problem II: When a new row with Reference 120:2-3 is added, the filter does not refresh the results. Hence, the new row is hidden until the filter is reset.
@abelpz abelpz mentioned this issue Feb 10, 2023
Merged
@abelpz abelpz self-assigned this Feb 10, 2023
@abelpz abelpz linked a pull request Feb 10, 2023 that will close this issue
Enhanced chapter verse filters #1536
Merged
@abelpz abelpz removed a link to a pull request Feb 10, 2023
Enhanced chapter verse filters #1536
Merged
@abelpz abelpz linked a pull request Feb 10, 2023 that will close this issue
Enhanced chapter verse filters #1536
Merged
@elsylambert elsylambert reopened this Feb 16, 2023
@elsylambert
Copy link
Contributor Author

This issue is fixed in - v1.10 build 228-f43ba9b.Screenshot 2023-02-15 at 10.34.26 PM.png

@elsylambert elsylambert added the QA/Passed QA Completed label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abelpz abelpz

Labels
QA/Passed QA Completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhanced chapter verse filters unfoldingWord/tc-create-app
2 participants
@abelpz @elsylambert