Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering by chapter in TSV7 #1493

Closed
birchamp opened this issue Dec 19, 2022 · 6 comments · Fixed by #1507 or #1536
Closed

Allow filtering by chapter in TSV7 #1493

birchamp opened this issue Dec 19, 2022 · 6 comments · Fixed by #1507 or #1536
Labels

Comments

@birchamp
Copy link
Contributor

Users want to be able to filter records down to all of the records in a single chapter of a book. Now that TSV7 has a string for the reference the filter no longer has a separate chapter field; however users need to check chapter by chapter.

DoD:
Users can filter to show only the records from a particular chapter.

@mandolyte
Copy link
Collaborator

This works already:
Screenshot 2022-12-19 4 34 43 PM

@birchamp
Copy link
Contributor Author

@mandolyte @larsgson When I do a search I get any note that includes the text '20:' because it searches all of the columns. Also the records don't show up in order for me.CleanShot 2022-12-27 at 10.35.13.png

@abelpz abelpz linked a pull request Jan 6, 2023 that will close this issue
@elsylambert
Copy link
Contributor

translationCore Create - v1.9.0 build 211-463611d. @abelpz The max limit to show the chapter verse is 18 and we cannot scroll beyond that. Screenshot 2023-01-10 at 9.55.53 AM.png

@abelpz
Copy link
Member

abelpz commented Jan 10, 2023

Thanks for finding this @elsylambert. I'll take a look

@abelpz
Copy link
Member

abelpz commented Jan 10, 2023

@elsylambert this PR should fix that #1510
@Joel-C-Johnson could you review it?

@elsylambert
Copy link
Contributor

Looks good in translationCore Create - v1.9.0 build 213-b124b37. Scroll bar is visible for Chapter and verse drop-downs. The selection from the filter and display of results are showing no delay. Works fine.

@elsylambert elsylambert added the QA/Passed QA Completed label Jan 12, 2023
@abelpz abelpz linked a pull request Feb 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants