Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests failing #131

Open
superdav42 opened this issue Jun 15, 2022 · 4 comments
Open

Unit tests failing #131

superdav42 opened this issue Jun 15, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@superdav42
Copy link
Contributor

We need to fix all unit tests which are failing.

npm run test:unit
Test Suites: 4 failed, 2 passed, 6 total
Tests:       60 failed, 29 passed, 89 total
Snapshots:   0 total
Time:        16.498s
Ran all test suites.

Also fix the github action so it actually run them. This would help https://github.com/unfoldingWord/datatable-translatable/blob/master/.github/workflows/nodejs.yml

@superdav42 superdav42 added the bug Something isn't working label Jun 15, 2022
@birchamp
Copy link

@Joel-C-Johnson @jincypjose ^^

@larsgson
Copy link
Contributor

larsgson commented Aug 3, 2022

I have now worked on at least some of the failing tests and adapted them so that they work again.
These changes are currently in this branch: https://github.com/unfoldingWord/scripture-resources-rcl/tree/feature-larsg-330-ampersandSupport and I have now created a PR for this branch.
I adapted the tests, which have not yet been fixed, so that they are skipped

@larsgson
Copy link
Contributor

larsgson commented Aug 3, 2022

Here are the two remaining tasks in order to get all tests running again:

  • The <ScriptureTable/> syntax probably needs to be updated to work with the latest version
  • Implement a new strategy for how to test functional components - probably by using React Testing Library instead of Enzyme (since Enzyme is no longer compatible with React 18)

@larsgson
Copy link
Contributor

larsgson commented Nov 24, 2022

I have started some more work in the direction to fix the testing - updated node and cypress:
https://github.com/unfoldingWord/scripture-resources-rcl/tree/larsg-bugfix-update-cypress-and-node
It is not yet fixed, however. The cypress testing seems to have problems in how it is set up and like @superdav42 mentioned further up here; github action also first needs to be looked into

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants