Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Disable "react/no-did-mount-set-state" #37

Closed
simenbrekken opened this issue Feb 27, 2017 · 1 comment
Closed

Disable "react/no-did-mount-set-state" #37

simenbrekken opened this issue Feb 27, 2017 · 1 comment

Comments

@simenbrekken
Copy link
Contributor

There's no way to do layout measuring or use async/await in componentDidMount with this rule in place. While it provides a nice safety net it's something you'd avoid by reflex after having worked with React a bit.

@simenbrekken
Copy link
Contributor Author

This is just smelly code, doing data fetching directly in the presentational component is probably bad, so I'm going to close this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant