Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort NBT data where applicable #280

Open
uncovery opened this issue Mar 22, 2017 · 3 comments
Open

Sort NBT data where applicable #280

uncovery opened this issue Mar 22, 2017 · 3 comments

Comments

@uncovery
Copy link
Owner

We might need to sort enchantment arrays to make sure 2 identical enchanted items can stack.
Most likely this is only needed when we store the item in the database.
We cannot sort everything since banner sequence changes the look.
Things to sort:

  • enchantments
  • potions?
  • fireworks?
@uncovery uncovery added this to the NBT tags enablement milestone Mar 22, 2017
@uncovery
Copy link
Owner Author

Enchantments are done.

@uncovery
Copy link
Owner Author

Potions (as the default potions) don't need to be sorted since they have only one effect

@uncovery uncovery added the bug label Mar 22, 2017
@uncovery
Copy link
Owner Author

uncovery commented Apr 1, 2017

Need to double-check if fireworks sorting makes a difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant