Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feed Event times always set to midnight for start and end time #141

Open
scttw opened this issue Nov 30, 2017 · 1 comment
Open

Feed Event times always set to midnight for start and end time #141

scttw opened this issue Nov 30, 2017 · 1 comment

Comments

@scttw
Copy link

scttw commented Nov 30, 2017

A recent change to the getFeedEvents function in Calendar.php is setting all feed events to have a start and end time of midnight. This appears to have been changed to allow a comparison to work, however the original times from the feed are not being re-set after they are set to 00:00:00. The result of this is all feed events display 12:00 as their start and end time when displayed in the template.

The modified variables at ln 35 and 36 should be saved into a new pair of comparison specific variables which are then discarded, rather than saving the modified variables back to the object.
@scttw
Copy link
Author

scttw commented Nov 30, 2017

Will submit a patch shortly

@scttw scttw mentioned this issue Dec 1, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scttw