Enable containerDefinitions portMappings to use target_groups container_ports #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 5, 2022 11:56
…p ports mapping is used
This was referenced May 5, 2022
josh-onchain
reviewed
May 5, 2022
josh-onchain
approved these changes
May 5, 2022
josh-onchain
previously approved these changes
May 6, 2022
|
Thanks for the contribution @networkprogrammer and the peer review @josh-onchain 🙌 - This is now released as 6.5.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit enables the module to prefer the
target_groupslist ofcontainer_portandprotocolovertask_container_port.If the target_groups does not have port and protocol specified, current behavior continues.