Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secrets to task defintion #28

Merged
merged 5 commits into from
Dec 9, 2020
Merged

Add secrets to task defintion #28

merged 5 commits into from
Dec 9, 2020

Conversation

ericduvic
Copy link
Contributor

Description

Fix issue #27: Added in variable task_container_secrets and a conditional entry into the task definition JSON to pass secrets to it.

@ericduvic ericduvic mentioned this pull request Dec 8, 2020
Closed
marcincuber
marcincuber approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@marcincuber marcincuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@marcincuber marcincuber merged commit 40cf22a into umotif-public:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcincuber marcincuber marcincuber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericduvic @marcincuber