Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions applied to form navigation don't work #893

Closed
Attackmonkey opened this issue Oct 6, 2022 · 3 comments
Closed

Conditions applied to form navigation don't work #893

Attackmonkey opened this issue Oct 6, 2022 · 3 comments

Comments

@Attackmonkey
Copy link

Attackmonkey commented Oct 6, 2022

When adding conditional logic to the page buttons in 10.1.2, the conditions are NOT applied and the buttons are always shown regardless of whether the conditions are satisfied.

Reproduction

Bug summary

If you add conditions to page buttons in forms, the conditions being met DO NOT cause the buttons to be hidden.

Specifics

Using the latest version of Forms (10.1.2) in Umbraco 10, page button conditions are broken.

Steps to reproduce

Create a simple form and add a condition to the page to show/hide the buttons. Display the form on a page and meet the condition, the buttons for the form will not be hidden. It doesn't seem to matter if the form is single or multi-page. Other conditions, e.g. field level ones, work as expected.

Expected result

If I apply a condition to the form buttons and that condition is met, the buttons should be hidden.

Actual result

Buttons are not hidden and are still visible, despite conditions having been met.

@Attackmonkey Attackmonkey changed the title Conditions applied to form navigation doesn't work Conditions applied to form navigation don't work Oct 6, 2022
@Attackmonkey
Copy link
Author

I can see the serialised configuration in the forms configuration div, it just doesn't seem to get hit sadly.

@AndyButland
Copy link

Thanks @Attackmonkey - I could replicate and think I've found the issue here, so will include a fix in the upcoming patch release.

@Attackmonkey
Copy link
Author

Awesome! Thanks @AndyButland, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants