Conditions removed when form is copied

[develoNiklas]

When copying a form with a conditional field the condition only partially copies over. This breaks the condition.

Reproduction

• Create a form with a single choice question
• Create a short answer with a condition that only will show the field if one of the single choice answers are selected
• Save form and make a copy
• The in the copy of the form the condition will be broken.

Specifics

• umbraco version: 8.12.2
• umbraco forms version: 8.7.1

Expected result

All fields in the condition should be copied

Actual result

the question alias is missing

[AndyButland]

I found this was happening as in a recent release we made an update to ensure field Ids are regenerated when copying forms, so they are unique across all form instances, in case two forms are presented on the same page.

What we hadn't done though was ensure that the conditions that are based on fields had their Ids updated to the newly generated ones. I've done that now, so will be available as a fix in the next release.