Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow settings are applied when clicking "Close" button #613

Closed
inetzo opened this issue Jul 29, 2021 · 1 comment
Closed

Workflow settings are applied when clicking "Close" button #613

inetzo opened this issue Jul 29, 2021 · 1 comment
Labels
release/8.8.0

Comments

@inetzo
Copy link

inetzo commented Jul 29, 2021 •
edited by Shazwazza
Loading

When you adjust the settings of a workflow, it doesn't matter if you click the Submit or the Close button of the dialog. In both cases, the settings are applied to the workflow.

Reproduction

  • Open the "Send template email" workflow and change the Recipient Email.
  • Click the "Close" button.
  • Open the "Send template email" workflow again, the settings are still applied

Expected result

I would expect that when clicking the "Close" button, the settings are not applied (only when clicking "Submit").

This item has been added to our backlog AB#13054
@AndyButland AndyButland added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Jul 29, 2021
@warrenbuckley
Copy link

Fixed in this PR
https://github.com/umbraco/Forms/pull/557

Due for release in 8.8.0

@umbrabot umbrabot removed the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release/8.8.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@warrenbuckley @AndyButland @inetzo @umbrabot