Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for answer types are too small #610

Closed
russellshome opened this issue Jul 20, 2021 · 8 comments
Closed

Icons for answer types are too small #610

russellshome opened this issue Jul 20, 2021 · 8 comments

Comments

@russellshome
Copy link

russellshome commented Jul 20, 2021

when choosing an answer type the icons are very small

Reproduction

Add a Form
Add a question
Choose answer type

Bug summary

in the previous version the css below is applied but not on the new version

.umb-card-grid i {
    font-size: 30px;
    line-height: 20px;
    margin-top: 6px;
    margin-bottom: 10px;
    display: block
}

Specifics

Version 8.7.6 of Forms

Version 8.15.0 of [Umbraco]

@russellshome
Copy link
Author

russellshome commented Jul 20, 2021

Icons in v 8.7.5

Icons in v 8 7 5

Icons in v 8.7.6

Icons in v 8 7 6

@AndyButland
Copy link

AndyButland commented Jul 21, 2021

Thanks for reporting. It looks like this is some CSS that was removed in the CMS for 8.15 - see here.

Hence I think it's that you've upgraded to CMS 8.15 that's caused this rather than the update of Forms to 8.7.6.

I'll check first to see if that's planned for restore there before adding it back for Forms.

@AndyButland
Copy link

I've reapplied this in forms, under a Forms-specific CSS selector, so the visual display is restored in Forms and we don't apply this styling to other areas of the back-office where it seems it's not longer necessary or wanted.

Expected to be released with 8.8.0.

@bjarnef
Copy link

bjarnef commented Jul 28, 2021

@AndyButland I adjusted part of this in Umbraco core to use <umb-icon> instead so it is also possible to use custom SVG icons.
Forms should probably use this as well.
#579

<umb-icon icon="icon-document" class="icon-document"></umb-icon>

@AndyButland
Copy link

Thanks @bjarnef, that seems to work so will go with that rather than porting over the CSS I think. To your knowledge has <umb-icon> been around for a while though? I need to consider latest version of Forms running on an older version of CMS V8.

@bjarnef
Copy link

bjarnef commented Jul 28, 2021

Yes, since Umbraco v8.8.0 as mentioned at bottom in the linked issue 🙂

It would be useful for custom field type and workflow to use a custom SVG icon. E.g. Forms could ship with a Slack icon for the workflows in Umbraco Forms folder in App_Plugins instead of the current chat icon 😁
https://our.umbraco.com/forum/using-umbraco-and-getting-started/106330-how-to-use-custom-svg-icons#comment-331354

@AndyButland
Copy link

Yes, works nicely:

@bjarnef
Copy link

bjarnef commented Jul 29, 2021

@AndyButland note it also need to set icon name in class attribute to be backward compatible with font icons in case people are using a custom font icon.

<umb-icon icon="icon-document" class="icon-document"></umb-icon>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants