Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Picker is missing placeholder #537

Closed
AaronSadlerUK opened this issue Apr 13, 2021 · 4 comments
Closed

Date Picker is missing placeholder #537

AaronSadlerUK opened this issue Apr 13, 2021 · 4 comments

Comments

@AaronSadlerUK
Copy link

AaronSadlerUK commented Apr 13, 2021

The date picker should have the placeholder configuration setting.

On forms which do not use labels, the field is completely blank, the placeholder is a supported attribute for this input type.


This item has been added to our backlog AB#11452

@nul800sebastiaan nul800sebastiaan added state/needs-investigation This requires input from HQ or community to proceed type/feature labels Apr 13, 2021
@nul800sebastiaan
Copy link
Member

Thanks, not sure why it's not implemented at the moment. Would you expect there to be a text in it, or a default date/time? Just looking for the practical use case here.. not sure I've seen date fields with a placeholder before. 🤔

@AaronSadlerUK
Copy link
Author

AaronSadlerUK commented Apr 13, 2021

@nul800sebastiaan On this particular clients form there are no labels, only placeholders, the date of birth field being the one in question.

I have created by own custom field type to solve this, however for what is 2 lines of code in the filedtype definition, I feel it should be there...

[Setting("Placeholder", Description = "Enter a HTML5 placeholder value", View = "TextField")]
        public string Placeholder { get; set; }

image

@nul800sebastiaan
Copy link
Member

Cool! I didn't realize the date field by default just looks like an empty textbox, definitely nice to allow a placeholder text there! 👍

@nul800sebastiaan nul800sebastiaan added state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks and removed state/needs-investigation This requires input from HQ or community to proceed labels Apr 15, 2021
@AndyButland
Copy link

Resolved in the linked PR and due in 8.7.2,

@umbrabot umbrabot removed the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants