Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emails with attachments are not send #486

Closed
FransdeJong opened this issue Feb 16, 2021 · 12 comments
Closed

Emails with attachments are not send #486

FransdeJong opened this issue Feb 16, 2021 · 12 comments

Comments

@FransdeJong
Copy link

Emails are not send if you add the attachments with the send email workflow.

To reproduce:

  • add a form with a upload
  • add a send email workflow
  • set attachment to true

If you set attachment to false it sends the emails.

Testen on Umbraco 8.11.1 and forms 8.6.0

@AndyButland
Copy link

Can I ask please if you using a custom media provider @FransdeJong? I.e. storing your media in Azure blob storage or similar rather than in the /media/ folder on disk?

If so, think this may be a duplicate of #477.

@FransdeJong
Copy link
Author

FransdeJong commented Feb 16, 2021 via email

@AndyButland
Copy link

OK, thanks, in which case I think that under that hood that will be using an Azure blob storage provider (suggested by documentation here), So believe this should be resolved by the fix to #477.

@FransdeJong
Copy link
Author

Great.
Any idea on when that will be released? This month, next month?

@AndyButland
Copy link

I don't, no, but I'll ping @nul800sebastiaan as he may be able to update (and if he and/or you agree, can close this ticket as a duplicate).

@nul800sebastiaan
Copy link
Member

I was thinking the same thing and while forms writes to the media folder, it doesn't by default participate in the blob storage provider as far as I know. A test on U8.11.1 / F8.6.0 turns out to give me a perfectly fine email with attachment, so something else must be going on. Anything in the logs @FransdeJong?

@nul800sebastiaan
Copy link
Member

And here's a screenshot of my email with attachment
image

Also, any specific file type that's being uploaded? Maybe a virus scanner is killing the uploads?

@FransdeJong
Copy link
Author

@nul800sebastiaan
Thanks for testing!
It looks like you used the "send email with template" workflow?
I'm using the "send email" workflow. Can you please test that workflow to?

@nul800sebastiaan
Copy link
Member

@FransdeJong Ah.. yes that one is broken. And that looks related to the fix Andy is referring to, I'll test that fix as well.

@nul800sebastiaan
Copy link
Member

Had a look: that's exactly what was already fixed as Andy said.

image

I ran a temp build and the two attached dlls are what you can use right now until a new version of Forms is out (I don't have a date yet, but hope it will be soon): Forms861pre.zip

I'll close this as a duplicate of #477!

@FransdeJong
Copy link
Author

Great!
Than I have one question left.
I know you can't tell me the exact date but when do you expect a release? One, two, three months?

@nul800sebastiaan
Copy link
Member

No no, more like next week or the week after 😅

I'm just in the process of figuring out what we put in an 8.6.1 patch release and then we'll ship it asap! I think only this one plus an examine indexing bug is what we need for a patch. Then there's some stuff ready for 8.7 but that will be a bit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants