Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing method after upgrade from 8.6 #1061

Closed
mhughes668 opened this issue Aug 7, 2023 · 1 comment
Closed

Missing method after upgrade from 8.6 #1061

mhughes668 opened this issue Aug 7, 2023 · 1 comment
Labels
release/8.13.11 state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks

Comments

@mhughes668
Copy link

mhughes668 commented Aug 7, 2023

After upgrading from Forms from 8.6 to 8.13.8 I have an error in UmbracoFormsExtensionsController.cs

"The name 'GoForward' does not exist in the current context"

I have compared the file between the 8.6 and 8.13.8 versions and they are the same - has the reference to 'GoForward' changed?

code for UmbracoFormsExtensionsController came from here - https://gist.github.com/lars-erik/7a0028f28b93385574b68ce11276bd7a

The only change that was made was upgrading from 8.6 forms to 8.3 forms using nuget. If I go back to 8.6 then I get no errors and the website works fine.

goforward2 goforward

This item has been added to our backlog AB#31793

@AndyButland
Copy link

AndyButland commented Aug 7, 2023

It looks like this was made private as opposed to protected back in 8.7. It shouldn't have been as that's a breaking change, so we can look at reverting this. It's historically a bit inconsistent as GoBackward is private in 8.6, so I can see why it got tidied up, but that change should have waited for the next major version.

@AndyButland AndyButland added state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks release/8.13.11 labels Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/8.13.11 state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks
Projects
None yet
Development

No branches or pull requests

2 participants