Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree view items do not show selected icon when selected #9209

Closed
matthew-darby opened this issue Oct 18, 2020 · 0 comments · Fixed by #9210
Closed

Tree view items do not show selected icon when selected #9209

matthew-darby opened this issue Oct 18, 2020 · 0 comments · Fixed by #9210
Labels
community/pr type/bug

Comments

@matthew-darby
Copy link
Contributor

matthew-darby commented Oct 18, 2020 •
edited
Loading

A regression caused by #9064 The tree views no longer show the green tick icon when you select an item.

The check icon was previously enabled/disabled by css (line 177 of umb-tree.less) which targeted <i>, but the icon now uses <umb-icon> so the CSS no longer targets it.

Umbraco version

I am seeing this issue on Umbraco version: v8/contrib

Reproduction

Steps to reproduce

  • Create any picker data type that uses tree view (MNTP, member group picker etc)
  • Select an item

Expected result

  • Icon should change to a tick

Capture

Actual result

  • Icon does not change/no indication item is selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community/pr type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Conditionally show check icon if umb-tree-item is selected
4 participants
@nathanwoulfe @hartviglarsen @matthew-darby @umbrabot