Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Failed to retrieve data after editing an uploaded image while creating a new node #7377

Closed
saifobeidat opened this issue Dec 20, 2019 · 6 comments

Comments

@saifobeidat
Copy link

saifobeidat commented Dec 20, 2019

I tried to edit an uploaded image while creating a new node and once I finish editing, it fails and I got a loading screen with errors on the console:

"errorMsg":"Failed to retrieve data for content id 1096","data":"","status":404

and on my screen I got:

Request error: The URL returned a 404 (not found):
/umbraco/backoffice/UmbracoApi/Content/GetById

Umbraco version

I am seeing this issue on Umbraco version: 8.4

Reproduction

Bug summary

Steps to reproduce

1- Create a new node
2- Upload an image
3- Edit the uploaded image ( fill any text in a new property ) and click on "Save and Close"

(GIF)
2019-12-20_15-56-50

Note that this issue doesn't occur when you edit an image from the media picker dialog

image

And also it doesn't occur when you try to edit an image of existing nodes (not new).

Expected result

Should be able to continue on node creation process

Actual result

Got a blank screen

@poornimanayar
Copy link
Contributor

Aah, thats annoying, I can reproduce the issue. Thanks for logging the issue. If you would like to help out fixing the issue, that will be great!

@umbrabot
Copy link

Hi @saifobeidat,

We're writing to let you know that we've added the Up For Grabs label to your issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly PR team bot :-)

@nathanwoulfe
Copy link
Contributor

nathanwoulfe commented Jan 12, 2020

I'm looking into this now - I think the problem is caused by an API call attempting to get content using the media item ID

Edit: sort of. Things were getting confused by not hiding code behind the infiniteMode flag - editor state was being updated, which caused a route update, but since we're in an infinite editor in the content section, the route was applying the media ID to a content path. I think. PR incoming.

@kjac
Copy link
Contributor

kjac commented Jan 13, 2020

Hmm I believe this is a duplicate of #7185, fixed in #7188 ?

@nathanwoulfe
Copy link
Contributor

Related, but different - the type attribute here is a duplicate change, but the route change and subsequent 404 is a different issue, specific to saving a media item when editing it from a new content node

@nul800sebastiaan
Copy link
Member

Fixed in #7449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants