Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Spacing the left and right side of the nested content item header-bar is too little #6312

Closed
nielslyngsoe opened this issue Sep 9, 2019 · 2 comments
Labels
category/ui User interface

Comments

@nielslyngsoe
Copy link
Member

nielslyngsoe commented Sep 9, 2019

The white space amount in each side of the header-bar of nested content items is too narrow.

Should be visually equivalent to the space between the Element-Type-Icon and the name, and the spacing between the action icons.

Thanks

image

@kjac
Copy link
Contributor

kjac commented Sep 9, 2019

@nielslyngsoe the padding was removed to make NC a bit more consistent with other icon-and-name style property editors like MNTP. See #5594 (specifically #5594 (comment)) for details.

I don't mind reverting it, but I just wanted to give you some context to this 😄

@nielslyngsoe
Copy link
Member Author

@kjac Aha! is properly the best word to describe my reaction ;-)

Thanks for remembering this! My 2,5 months of paternity leave left me without this memory. But I clearly see the argument, and my own comment...

Seen from a visual perspective both things are right and would in a perfect world become true... #1 they should align, #2 there should be equivalent spacing around the icons.

So the task escalated a bit, I will return when I have investigated the consequence of increasing the space on all lists items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/ui User interface
Projects
None yet
Development

No branches or pull requests

2 participants