v8: Using keyboard to cancel in modal triggers primary action

[electricsheep]

Bug summary

If you have a one of the Save and publish option modals open (i.e. Schedule/Publish with descendants/Unpublish) and tab so that the Close button is focused, hitting Enter will trigger the primary action rather than closing the modal.

Specifics

• Umbraco v8.1.0
• Chrome 74

Steps to reproduce

1. Open a page in the CMS
2. Expand the menu next to Save and publish
3. Click Unpublish
4. Tab to the Close button on the modal
5. Hit Enter key

Expected result

The modal is closed without unpublishing

Actual result

The page is unpublished

[kjac]

Yeah... this is annoying. PR #5463 aims to solve it.

[kjac]

And also #5461 which fixes the unintentional triggering of the secondary action in "Unsaved changes"

[nul800sebastiaan]

Ah looks like these are both fixed now, just forgot to close the issue! :)