V8: Can we add javascript source maps to the back office?

[PeteDuncanson]

Source maps are a wonderful aid to helping debug issues in minified javascript files. I wondered if it was possible/worth while to add them to the back office js build process so that they would be available in browsers during use.

I worry that with debug=false set everything would be compressed via Client Dependency which I don't think is source map aware. The issue here is that the source maps would be generated for each of the js bundles needed for the back office (take /umbraco.web.ui/umbraco/js/umbraco.directives.js for instance) via the build process. But when in production mode (debug=false) CD would lump all these js files together and I don't think the source maps will work (as they are for standalone bundles not a re-bundling of bundles!).

I've posted a question up for Shannon on the CD site to see if we can get an answer/thoughts.

Shazwazza/ClientDependency#161

[PeteDuncanson]

Would probably add something like this if we went this route https://github.com/gulp-sourcemaps/gulp-sourcemaps

[nul800sebastiaan]

CDF might not be able to handle it but when debug=true, does it make sense to do this still?

Note: I have absolutely no idea what I'm talking about so please forgive the naive question.

[Shazwazza]

It would be cool if we can do it, it would require an update on CDFs part to not minify already minified files (which makes perfectly good sense anyways), then it would be a POC to figure out if we can generate the source maps with gulp and have them appended as part of the CDF bundle. I'm sure it's possible but first need to update CDF to ignore .min.js files and then could start a POC (or @PeteDuncanson can ;) )

[umbrabot]

Hiya @PeteDuncanson,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant
This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂