Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: Ensure all other elements can't be focused while infinite editing is active (Focus/Tab lock) #4525

Closed
BatJan opened this issue Feb 11, 2019 · 2 comments
Labels
category/accessibility category/ux User experience status/idea The ideas in this issue are great idea, we're not ready to work on it in the near future.

Comments

@BatJan
Copy link
Contributor

BatJan commented Feb 11, 2019

In order to ensure accessibility and a pleasant user experience when using infinite editing I suggest that we include the inert polyfill from https://github.com/WICG/inert, which will mimic expected browser behavior once this attribute is implemented into browsers.

Whenever an element has the "inert" attribute itself and it's children can't be interacted with.

Currently when tabbing through the infinite overlay focus is not kept within it, which is demonstrated in this little video https://www.youtube.com/watch?v=es8i3ALmmm0&feature=youtu.be - Notice how the app section items are being highlighted and also the pagename in the layer behind the infinite layer.

I have been poking around the codebase this evening and I think I have an idea about how this can be achieved so I will open a PR for it - I will probably need some HQ input for some of it. But I'll let you know when I have something that can be checked out etc.

To get an idea about what I suggest the outcome should be please have a look at this CodePen demo, which illustrates the concept perfectly (Not using inert though): https://codepen.io/matuzo/pen/GrNdvK

@clausjensen clausjensen added the status/idea The ideas in this issue are great idea, we're not ready to work on it in the near future. label Feb 12, 2019
@BatJan BatJan changed the title v8: Ensure all other elements can't be focused while infinite editing is active v8: Ensure all other elements can't be focused while infinite editing is active (Focus/Tab lock) Mar 24, 2019
@Shazwazza Shazwazza added the category/ux User experience label Apr 2, 2019
@melvinvanrookhuizen
Copy link

@nul800sebastiaan tested against v8.9, seems solved. asl also #5463 is merged

@nul800sebastiaan
Copy link
Member

Late reply, but yes, let's close this one as fixed! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/accessibility category/ux User experience status/idea The ideas in this issue are great idea, we're not ready to work on it in the near future.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants