Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Move" to trashed items #3769

Closed
kjac opened this issue Nov 26, 2018 · 0 comments
Closed

Add "Move" to trashed items #3769

kjac opened this issue Nov 26, 2018 · 0 comments

Comments

@kjac
Copy link
Contributor

kjac commented Nov 26, 2018

When you move a child node to trash and then subsequently moves its parent to trash, the child can no longer be restored, because the original parent is in the trash. And if the parent has been deleted explicitly from the trash, the child can never be restored.

Since we rely on editors being able to move things around in the tree, wouldn't it be reasonable to rewrite the restore functionality to become a simple move operation instead?

content-restore-redo-demo

I'd be happy to do the work. I've got most of it working already, as you can see.

Update: I realized there's supposed to be a "Move" option to complement "Restore" - but it's not there. This applies to both V7 and V8. I'll prepare a PR.

image

@kjac kjac changed the title V8: Rethink the "Restore" function V8: Add "Move" to trashed items Nov 27, 2018
@kjac kjac changed the title V8: Add "Move" to trashed items Add "Move" to trashed items Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants