Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem updating/ editing a tab titled "Generic properties" #12240

Closed
ewanexer opened this issue Apr 8, 2022 · 5 comments
Closed

Problem updating/ editing a tab titled "Generic properties" #12240

ewanexer opened this issue Apr 8, 2022 · 5 comments
Labels

Comments

@ewanexer
Copy link

ewanexer commented Apr 8, 2022

Which exact Umbraco version are you using? For example: 9.0.1 - don't just write v9

Umbraco 7.15.3, Umbraco 8.17.1, Umbraco 9.0.0

Bug summary

I have a few doc types with custom tabs called "Generic properties". This was an inheritance of Umbraco 6 where the tab with generic content properties was called like this - I wanted to add some properties to the same tab so I created a tab with exactly the same name as the generic tab.

In Umbraco 7 this generic tab was renamed to "Info" and the custom "Generic properties" tab was no a problem, it just existed as another tab.

Specifics

After upgrading to Umbraco 8 and then Umbraco 9 I noticed that the tab called "Generic properties" no longer displays when editing the page using it. In Umbraco 8 the tab displays in the content but it has the name "Properties" (not "Generic properties").

I tried to rename the tab in doc type but that did not work (the update did not save): when trying to rename the tab in Umbraco 8 - I put the cursor in the tab name field and try to write a new name - the tab simply disappears from the doc type!

When editing the tab name in Umbraco 9 it appears to take long time to save, looks like saved and then the tab name does not change in the page content.

Also in Umbraco 7 I now noticed - it is not possible to change the tab name either from "Generic properties" to another name. Saving has the same effect like in Umbraco 8 - the doc type saves but when coming back to the doc type or the content - the tab name persists as "Generic properties".

Steps to reproduce

The example screenshot show the effect in Umbraco 8
Generic-tab-disappears

Expected result / actual result

It should allow to rename a custom tab name no matter what the name is.

@ewanexer
Copy link
Author

ewanexer commented Apr 8, 2022

I further noticed that I am not able to delete the custom "Generic properties" tab from a doc tab on Umbraco 7.15.3

@JarnoVWA
Copy link

JarnoVWA commented May 6, 2022

+1 for Umbraco v8.18.3. The exact same behaviour as shown in the gif/video. Unable to save the document type with error "Validation: The Alias field is required."
When trying to change the name it clears all properties and property-groups in the document type as shown in the gif/video.

In the database, table cmsPropertyTypeGroup does not have an entry for the "Generic properties" tab.
The properties in this tab do exist in table cmsPropertyType but with propertyTypeGroupId = NULL

Edit: https://our.umbraco.com/forum/using-umbraco-and-getting-started/108754-problem-updating-editing-a-tab-titled-generic-properties has a manual workaround, by reordering properties into a different property-group you can delete the "Generic properties" and save afterwards.

@nul800sebastiaan
Copy link
Member

Have you tried the "Reorder" button to put things in proper groups/tabs?

image

@christianfredh
Copy link

christianfredh commented Jul 20, 2022

FYI: Same issue (as video) here using 8.18.4 as well. Currently upgrading from 7.15.7, but installation has been around since v6 or something.

So still an issue when migrating from older versions. I can use the workaround, so will probably get around it however.

Workaround steps:

  1. Add group: Generic (or what you want to call it)
  2. "Reorder"
  3. Drag properties in "Generic properties" to new group
  4. "I am done reordering"
  5. Delete the "Generic properties" group
  6. "Save"

@nikolajlauridsen
Copy link
Contributor

Hey all, just had another look.

I can no longer reproduce this in V10+, so it has probably been fixed at some point, possibly as part of #11202

Since we no longer back-port fixes to V8 unless they concern critical security issues, I'm afraid I'll have to close down this issue, however, on the plus side it seems like @christianfredh has a great work around 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants