Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content editor icon not initialized correctly #11281

Closed
bjarnef opened this issue Oct 5, 2021 · 6 comments · Fixed by #11283
Closed

Content editor icon not initialized correctly #11281

bjarnef opened this issue Oct 5, 2021 · 6 comments · Fixed by #11283
Labels

Comments

@bjarnef
Copy link
Contributor

bjarnef commented Oct 5, 2021

Which exact Umbraco version are you using? For example: 8.13.1 - don't just write v8

8.17.0

Bug summary

After pulling latest changes from v8/contrib branch, I noticed existing selected icons in header was not initialized correctly and fallback to default icon-document.

image

Even when re-selecting icon and saving the document type again it set icon-document.

T7Qv4Glqbs.mp4

Specifics

No response

Steps to reproduce

Select a custom icon on a document type and note is showing icon-document when refreshing page.

Expected result / actual result

No response

@bjarnef bjarnef changed the title Content editor icon not loaded correctly Content editor icon not initialized correctly Oct 5, 2021
@bjarnef
Copy link
Contributor Author

bjarnef commented Oct 5, 2021

@nul800sebastiaan do you know if something has recently changed regarding this? 🤔

@nul800sebastiaan
Copy link
Member

Maybe this one? #11008

@bjarnef
Copy link
Contributor Author

bjarnef commented Oct 5, 2021

Yes, it add icon to query params and if null it fallback to icon-document.
But that won't work for all existing document types, which by default doesn't have icon querystring param.

In this example route only has the following: /umbraco#/settings/documentTypes/edit/1150?mculture=en-US

It does seem in only affect document types and not media and member types.

@bjarnef
Copy link
Contributor Author

bjarnef commented Oct 5, 2021

Fixed in #11283

@bjarnef
Copy link
Contributor Author

bjarnef commented Oct 5, 2021

Another strange issue I noticed is when creating an element type it also creates a template 🤔
Reported in #11285

@nul800sebastiaan
Copy link
Member

Fixed in #11283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants