-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some stylesheet imports get excluded in vite build #49
Comments
Hey @troyvassalotti, thank you so much for reporting this! When Vite released the |
Thanks @umbopepato! Yeah #50 is a weird one because it seems to involve this plugin & Storybook & Vite all together so it's hard to pinpoint the underlying issue, but I appreciate whatever time you have! |
Fixes #14142 Added rollup-plugin-postcss-lit and configured it to handle all CSS files except those under theme folder. Note the extra entry with ? is necessary until umbopepato/rollup-plugin-postcss-lit#49 fixed. Another entry added to excludes to workaround umbopepato/rollup-plugin-postcss-lit#52
I updated the default include glob so this should be solved. Feel free to reopen if the problem still exists |
We have a vite project that uses this plugin in conjunction with Storybook and their vite builder. This plugin worked great out of the box when running the Storybook development server, but the plugin was not working when we built the static Storybook pages for publishing.
After opening an issue in the vite builder repo, the maintainer provided a fix that has to do with this plugin's default
include
setting. The link to his solution is here and I've copied it below for quick reference:I can confirm that the above edits fixed our issue. Is this something worth adjusting the default
include
for?The text was updated successfully, but these errors were encountered: