Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync): display an alert when disconnected #2501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yohanboniface
Copy link
Member

Seems a bit agressive to me (maybe because the alert is so wide ?).

@Aurelie-Jallut thoughts ?

image

fix #2500
cf #2235

@Aurelie-Jallut
Copy link
Collaborator

we can keep the usual size and use the same principle for validation or information messages, but here with a warning icon + red title .

image

@Aurelie-Jallut
Copy link
Collaborator

Maybe we can replace the "Have fun" by something else ; )

image

@yohanboniface
Copy link
Member Author

Alerts of type error usually render like this, we don't have (yet?) the colored title (red nor green):

Screenshot From 2025-01-23 11-54-29

@almet
Copy link
Member

almet commented Feb 12, 2025

For the record, here is the phrasing I proposed last time. Not saying it should be this, but putting it here in case it helps somehow.

Here be dragons.

This map has enabled real-time synchronization with other users, but you are currently disconnected. We will try to reconnect in the background and reconcile with other users, but this feature is still experimental, and you might lose data. Have fun!

I personally especially like the "here be dragons" part, because I find it fun, but maybe that's my nerd part talking here 🙊

@yohanboniface
Copy link
Member Author

I personally especially like the "here be dragons" part, because I find it fun, but maybe that's my nerd part talking here 🙊

Je trouve ça amusant aussi (mais je le verrais plutôt en latin), mais à mon avis, ça dépend à qui on s'adresse, et je pense que le commun des mortels qui aura ce message n'aura pas la référence. Mais on pourrait mettre une icône de dragon ou un truc du genre pour que soit moins élitiste.

Aussi peut-être que c'est pas là qu'il faut mettre le message mais au moment où on passe une carte en "collaborative", pour bien prévenir que c'est une fonctionnalité expérimentale ? Enfin, l'un n'empêche pas l'autre… :p

@yohanboniface
Copy link
Member Author

Tests are broken because with this implementation, websocket import Alert, which imports translate, which imports Leaflet, which needs window but it is not available in our JS tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alert "here be dragons"
3 participants