Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yesqa to precommit checks #7511

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Conversation

Zengyf-CVer
Copy link
Contributor

@Zengyf-CVer Zengyf-CVer commented Apr 21, 2022

I fixed yesqa.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Integration of yesqa tool to manage Python code's 'noqa' comments.

πŸ“Š Key Changes

  • Un-commented the yesqa configuration in the .pre-commit-config.yaml file, making it an active part of the pre-commit checks.
  • Updated the yesqa tool to version v1.3.0.

🎯 Purpose & Impact

  • Enhanced Code Quality: Aids in the automatic removal of unnecessary # noqa comments, ensuring they're only used when required.
  • Streamlined Development: Improves the pre-commit process, offering developers a cleaner code base and assisting with maintaining coding standards.
  • User Benefit: Developers working on the Ultralytics/yolov5 codebase will experience less clutter and better adherence to Python coding conventions.

@Zengyf-CVer Zengyf-CVer changed the title Fix yesqa and add Python dependencies security check Fix yesqa Apr 21, 2022
@glenn-jocher glenn-jocher changed the title Fix yesqa Add yesqa to precommit checks Apr 21, 2022
@glenn-jocher glenn-jocher merged commit 6ea81bb into ultralytics:master Apr 21, 2022
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Update .pre-commit-config.yaml

* Update .pre-commit-config.yaml
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Update .pre-commit-config.yaml

* Update .pre-commit-config.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants