Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish.yml Slack step #225

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix publish.yml Slack step #225

merged 1 commit into from
Nov 19, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 19, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced GitHub Actions notification with detailed pull request information and title in alerts.

πŸ“Š Key Changes

  • Updated the Slack notification format in the GitHub Actions workflow.
  • Incorporated the pull request title (${{ env.PR_TITLE }}) into the alert message.

🎯 Purpose & Impact

  • Enhanced Clarity: Provides more context by including the PR title in error notifications, aiding in quicker understanding and resolution. πŸ› οΈ
  • Improved Communication: Facilitates better team awareness with specific information about each PR in alerts. πŸ“£

@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Nov 19, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/hub-sdk πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues if applicable. Make sure your commit messages are clear, concise, and follow project conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/hub-sdk main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify that all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please investigate and resolve the issues.
  • βœ… Update Documentation: Make sure to update the documentation for any new or altered features to keep it accurate and helpful.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the essentials necessary for your bug fix or feature addition. As the famous Bruce Lee said, "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is."

For more detailed guidance, refer to our Contributing Guide. If you have any questions or need clarification, feel free to leave a comment. An Ultralytics engineer will review your PR soon. Thanks for contributing to Ultralytics! πŸŽ‰

@glenn-jocher glenn-jocher merged commit 40c449e into main Nov 19, 2024
4 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch November 19, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants