Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WebSockets over SSL #171

Closed
adamjs opened this issue Sep 30, 2019 · 3 comments
Closed

Add support for WebSockets over SSL #171

adamjs opened this issue Sep 30, 2019 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@adamjs
Copy link
Member

adamjs commented Sep 30, 2019

Our branch of WebCore (specifically, cURL requests) doesn't support WebSockets over SSL-- upstream trunk has the fix, just need to pull and merge.

@adamjs adamjs added the bug Something isn't working label Sep 30, 2019
@adamjs adamjs added this to the v1.2 milestone Sep 30, 2019
@adamjs adamjs self-assigned this Sep 30, 2019
@adamjs
Copy link
Member Author

adamjs commented Apr 22, 2020

This is now working in latest 1.2 branch.

@adamjs adamjs closed this as completed Apr 22, 2020
@TheAFOGroup
Copy link

Unfortunately, I just tested this using Sample 8 and it does not work. Websockets over SSL do not work.

Any suggestions ? :(

Screenshot_9

@TheAFOGroup
Copy link

TheAFOGroup commented Apr 1, 2021

This is a websocket request on Chrome:

Accept-Encoding: gzip, deflate, br
Accept-Language: en-GB,en-US;q=0.9,en;q=0.8
Cache-Control: no-cache
Connection: Upgrade
Host: ...
Origin: ....
Pragma: no-cache
Sec-WebSocket-Extensions: permessage-deflate; client_max_window_bits
Sec-WebSocket-Key: JJFMPsLQK9uaNP/svt5CBQ==
Sec-WebSocket-Version: 13
Upgrade: websocket
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.90 Safari/537.36

As you can see it's just missing Upgrade: websocket, if you can add that... problem solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant